aws-samples / aws-samples/sample-autonomous-cloud-coding-agents

Orchestrator/ Memory: Implement review feedback memory loop so agents learn from PR reviews

オープン
#27 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る
agent-runtime orchestration
主要言語
TypeScript
スター
143
フォーク
46
平均マージ
3日 10時間
マージ済み PR(30日)
24

説明

### Component

API or orchestration

### Describe the feature

> This issue depends on #26

This addresses the "Review feedback memory loop (Tier 2)" item from Iteration 3d in the roadmap.

The agent doesn't learn from PR reviews. If a reviewer leaves comments like "use zod for validation", "return 201 for creation endpoints", "use our errorHandler middleware" - those corrections apply to every future task on that repo, but the agent has no way to internalize them. The next task on the same repo will repeat the same mistakes, and the reviewer has to leave the same comments again.

The memory system (Iteration 3b) already supports writing and reading repo-level knowledge. The webhook infrastructure (Iteration 3a) already handles inbound events. What's missing is the pipeline that connects PR review comments to persistent memory.

### Use case

I submitted a `new_task` to create an API endpoint. The agent delivered working code but without request validation, wrong HTTP status codes, and inline error handling instead of the repo's middleware pattern. I left 3 review comments. Then I submitted another task for a different endpoint on the same repo - the agent made the exact same mistakes because it had no memory of my feedback.

### Proposed solution

Use the existing webhook infrastructure to capture `pull_request_review` events and extract actionable rules into memory.

**Flow:**

1. Reviewer leaves comments on an agent-created PR
2. GitHub sends a `pull_request_review` webhook event
3. A new handler (separate from the task-creation webhook) receives the event, fetches the diff + comments
4. A Bedrock call extracts rules from the comments, classifying each as:
- **Repo-level**: "use zod for validation on all endpoints" - applies to all future tasks
- **Task-specific**: "this function needs a null check" - context for this task only
5. Rules are written to AgentCore Memory with `source_type: review_feedback` provenance
6. On the next task for that repo, `loadMemoryContext()` loads these rules during hydration - the agent starts already knowing the repo's conventions

**A real example:**

Review comments: "validate with zod", "return 201 for POST", "use errorHandler middleware"

Next task prompt includes:
```
Repository knowledge (from past reviews):
- Use zod for request body validation on all endpoints
- POST endpoints that create resources must return HTTP 201
- Use errorHandler middleware, not inline try/catch
```

The agent applies all three without the reviewer repeating themselves.

**What's we need to add:**
- A webhook handler for `pull_request_review` events (the current handler only creates tasks)
- An extraction Lambda with a Bedrock prompt to turn review comments into structured rules
- Provenance tagging on memory writes (`source_type: review_feedback`) so trust scoring (Iteration 3e) can weight these appropriately

### Other information

_No response_

### Acknowledgements

- [x] I may be able to implement this feature
- [ ] This might be a breaking change

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

既存の webhook インフラストラクチャ、Iteration 3b のメモリシステム、issue #26 の確認から始めてください。現在のタスク作成 webhook と loadMemoryContext() を追跡し、pull_request_review イベント、diff とコメントの取得、Bedrock 抽出、source_type のプロベナンスがどのようにつながるかを明らかにしてください。完了とは、リポジトリレベルのレビュー ルールが永続化され、後続のタスクに読み込まれる一方で、タスク固有のフィードバックが適切なスコープに維持されることです。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
aws, github, typescript
領域
ai, api, backend, cloud
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
38/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。