aws-samples / aws-samples/sample-autonomous-cloud-coding-agents

Orchestrator/ Memory: Implement review feedback memory loop so agents learn from PR reviews

Abierto
#27 0 comentarios 1 reacción 0 asignados Ver en GitHub
agent-runtime orchestration
Lenguaje dominante
TypeScript
Estrellas
143
Forks
46
Merge medio
3 d 10 h
PR fusionados (30 d)
24

Descripción

### Component

API or orchestration

### Describe the feature

> This issue depends on #26

This addresses the "Review feedback memory loop (Tier 2)" item from Iteration 3d in the roadmap.

The agent doesn't learn from PR reviews. If a reviewer leaves comments like "use zod for validation", "return 201 for creation endpoints", "use our errorHandler middleware" - those corrections apply to every future task on that repo, but the agent has no way to internalize them. The next task on the same repo will repeat the same mistakes, and the reviewer has to leave the same comments again.

The memory system (Iteration 3b) already supports writing and reading repo-level knowledge. The webhook infrastructure (Iteration 3a) already handles inbound events. What's missing is the pipeline that connects PR review comments to persistent memory.

### Use case

I submitted a `new_task` to create an API endpoint. The agent delivered working code but without request validation, wrong HTTP status codes, and inline error handling instead of the repo's middleware pattern. I left 3 review comments. Then I submitted another task for a different endpoint on the same repo - the agent made the exact same mistakes because it had no memory of my feedback.

### Proposed solution

Use the existing webhook infrastructure to capture `pull_request_review` events and extract actionable rules into memory.

**Flow:**

1. Reviewer leaves comments on an agent-created PR
2. GitHub sends a `pull_request_review` webhook event
3. A new handler (separate from the task-creation webhook) receives the event, fetches the diff + comments
4. A Bedrock call extracts rules from the comments, classifying each as:
- **Repo-level**: "use zod for validation on all endpoints" - applies to all future tasks
- **Task-specific**: "this function needs a null check" - context for this task only
5. Rules are written to AgentCore Memory with `source_type: review_feedback` provenance
6. On the next task for that repo, `loadMemoryContext()` loads these rules during hydration - the agent starts already knowing the repo's conventions

**A real example:**

Review comments: "validate with zod", "return 201 for POST", "use errorHandler middleware"

Next task prompt includes:
```
Repository knowledge (from past reviews):
- Use zod for request body validation on all endpoints
- POST endpoints that create resources must return HTTP 201
- Use errorHandler middleware, not inline try/catch
```

The agent applies all three without the reviewer repeating themselves.

**What's we need to add:**
- A webhook handler for `pull_request_review` events (the current handler only creates tasks)
- An extraction Lambda with a Bedrock prompt to turn review comments into structured rules
- Provenance tagging on memory writes (`source_type: review_feedback`) so trust scoring (Iteration 3e) can weight these appropriately

### Other information

_No response_

### Acknowledgements

- [x] I may be able to implement this feature
- [ ] This might be a breaking change

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza revisando la infraestructura de webhooks existente, el sistema de memoria de Iteration 3b y issue #26. Sigue el webhook actual de creación de tareas y loadMemoryContext(), y determina cómo se relacionan los eventos pull_request_review, la recuperación de diffs y comentarios, la extracción de Bedrock y la procedencia de source_type. Se considera terminado cuando las reglas de revisión a nivel de repositorio se persisten y se cargan en tareas posteriores, mientras que el feedback específico de la tarea permanece correctamente delimitado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
aws, github, typescript
Área
ai, api, backend, cloud
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.