aws-cloudformation / aws-cloudformation/cloudformation-cli-typescript-plugin

when trying to change the template to use nodejs20.x the build is failed

Open
#121 9 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
46
Forks
18
PR merge metrics
No merged PRs in 30d

Description

I am trying to create resource provider using Typescipt. I saw that the template is using node 14 - which is very old.
i have tried to use node 20. however cfn submit fail with error

command '['npm install --include=optional && sam build --debug --build-dir /Users/liraz/work/skywalker/server/netapp-cfn/export-policy/build --use-container TypeFunction']' returned non-zero exit status 1.

when running the npm install explicitly i am getting an error
`Error: NodejsNpmBuilder:NpmPack - NPM Failed: npm notice
npm notice New patch version of npm available! 10.2.3 -> 10.2.5
npm notice Changelog:
npm notice Run `npm install -g npm@10.2.5` to update!
npm notice
npm ERR! code 2
npm ERR! path /tmp/samcli/source
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! > netapp-fsx-svmpeer@0.1.0 build
npm ERR! > npx tsc
npm ERR!
npm ERR! error TS5033: Could not write file '/tmp/samcli/source/dist/handlers.js': EROFS: read-only file system, open '/tmp/samcli/source/dist/handlers.js'.
npm ERR! error TS5033: Could not write file '/tmp/samcli/source/dist/models.js': EROFS: read-only file system, open '/tmp/samcli/source/dist/models.js'.
npm ERR! npm WARN config optional Use `--omit=optional` to exclude optional dependencies, or
npm ERR! npm WARN config `--include=optional` to include them.
npm ERR! npm WARN config
npm ERR! npm WARN config Default value does install optional deps unless otherwise omitted.
npm ERR! npm WARN config optional Use `--omit=optional` to exclude optional dependencies, or
npm ERR! npm WARN config `--include=optional` to include them.
npm ERR! npm WARN config
npm ERR! npm WARN config Default value does install optional deps unless otherwise omitted.

npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-12-07T21_50_45_696Z-debug-0.log
➜ cfnrp npm install --include=optional && sam build --debug --build-dir /Users/liraz/work/cfnrp/build --use-container TypeFunction
npm WARN config optional Use `--omit=optional` to exclude optional dependencies, or
npm WARN config `--include=optional` to include them.
npm WARN config
npm WARN config Default value does install optional deps unless otherwise omitted.
`

moving back to node14 and all is fine

Contributor guide

Open the contributing guide

Research direction

The issue names the TypeScript build path through npm run build, npx tsc, and sam build for TypeFunction; start by reproducing the Node.js 20 build and inspecting the template and build configuration that select the runtime. Done means the Node.js 20 template completes npm install and sam build without the EROFS or TS5033 errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, nodejs, typescript
Domain
build-system, cloud, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.