apex / apex/up

Crystal support improvements

未关闭
#226 8 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Go
星标
8.8k
派生
383
PR 合并指标
30 天内没有已合并 PR

描述

I'd like to improve Crystal support for up - it currently only works with a ``main.cr`` which is older-school. The current standard practice is to have a ``shard.yml`` which describes the app and targets. Suggestions:

1. I fix #172 - yes there is an official image + can move to ``--release``
2. Add yaml parsing, pull out the (first - to start) target from the ``shard.yml`` file and build that instead of forcing ``main.cr``.

FYI: I made a simple demo app with Kemal that imho should "just work" but doesn't due to issue 2 above -- see https://github.com/ukd1/up-crystal-demo - result after running ``up`` on it is this (as it doesn't detect crystal):

screen shot 2017-08-12 at 9 57 00 pm

@tj thoughts?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。