apex / apex/up

Crystal support improvements

Offen
#226 8 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Go
Sterne
8.8k
Forks
383
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

I'd like to improve Crystal support for up - it currently only works with a ``main.cr`` which is older-school. The current standard practice is to have a ``shard.yml`` which describes the app and targets. Suggestions:

1. I fix #172 - yes there is an official image + can move to ``--release``
2. Add yaml parsing, pull out the (first - to start) target from the ``shard.yml`` file and build that instead of forcing ``main.cr``.

FYI: I made a simple demo app with Kemal that imho should "just work" but doesn't due to issue 2 above -- see https://github.com/ukd1/up-crystal-demo - result after running ``up`` on it is this (as it doesn't detect crystal):

screen shot 2017-08-12 at 9 57 00 pm

@tj thoughts?

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.