apex / apex/up

Crystal support improvements

Ouverte
#226 8 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
Go
Étoiles
8.8k
Forks
383
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I'd like to improve Crystal support for up - it currently only works with a ``main.cr`` which is older-school. The current standard practice is to have a ``shard.yml`` which describes the app and targets. Suggestions:

1. I fix #172 - yes there is an official image + can move to ``--release``
2. Add yaml parsing, pull out the (first - to start) target from the ``shard.yml`` file and build that instead of forcing ``main.cr``.

FYI: I made a simple demo app with Kemal that imho should "just work" but doesn't due to issue 2 above -- see https://github.com/ukd1/up-crystal-demo - result after running ``up`` on it is this (as it doesn't detect crystal):

screen shot 2017-08-12 at 9 57 00 pm

@tj thoughts?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.