apache / apache/datafusion-sqlparser-rs

Fix licensing issues in source release found during 0.63.0 RC1 vote (missing NOTICE file, flamegraph.svg with CDDL-licensed JavaScript)

未關閉 適合新手
#2,495 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Rust
星號
3.5k
分支
772
平均合併
4 天 9 小時
30 天內合併 PR
17

描述

**Describe the bug**

During the vote on the Apache DataFusion sqlparser-rs `0.63.0` RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmx

1. **Missing `NOTICE` file**: the source archive contains `LICENSE.TXT` but no `NOTICE` file, which ASF releases are expected to include.
2. **`sqlparser_bench/img/flamegraph.svg` embeds third-party licensed code**: the generated flamegraph embeds JavaScript from [Inferno](https://github.com/jonhoo/inferno), whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.

**To Reproduce**

Download and unpack the 0.63.0 RC1 source archive (or check the repository at `v0.63.0-rc1`):

```shell
$ ls NOTICE*
ls: NOTICE*: No such file or directory

$ grep -c -i inferno sqlparser_bench/img/flamegraph.svg
2
```

**Expected behavior**

The source release complies with ASF licensing policy:

1. Add a `NOTICE` file to the repository so it is included in source archives.
2. Exclude the generated `sqlparser_bench/img/flamegraph.svg` from the source release

**Additional context**

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

從 repository 根目錄開始,使用 0.63.0-rc1 原始碼封存檔並檢查 NOTICE、LICENSE.TXT 和 sqlparser_bench/img/flamegraph.svg;執行 issue 中的 ls 和 grep 檢查以確認發現。完成的標準是原始碼發行版包含必要的 NOTICE 檔案,並排除產生的 flamegraph.svg,同時不保留採用 CDDL 授權的 JavaScript。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
rust
領域
release
Issue 類型
缺陷
難度
2/5
預估耗時
1-2 天
活躍度
活躍
描述清晰度
描述清楚
新手友好度
72/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。