apache / apache/datafusion-sqlparser-rs
Fix licensing issues in source release found during 0.63.0 RC1 vote (missing NOTICE file, flamegraph.svg with CDDL-licensed JavaScript)
- Langage dominant
- Rust
- Étoiles
- 3.5k
- Forks
- 772
- Merge moyen
- 4 j 9 h
- PR mergées (30 j)
- 17
Description
**Describe the bug**
During the vote on the Apache DataFusion sqlparser-rs `0.63.0` RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmx
1. **Missing `NOTICE` file**: the source archive contains `LICENSE.TXT` but no `NOTICE` file, which ASF releases are expected to include.
2. **`sqlparser_bench/img/flamegraph.svg` embeds third-party licensed code**: the generated flamegraph embeds JavaScript from [Inferno](https://github.com/jonhoo/inferno), whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.
**To Reproduce**
Download and unpack the 0.63.0 RC1 source archive (or check the repository at `v0.63.0-rc1`):
```shell
$ ls NOTICE*
ls: NOTICE*: No such file or directory
$ grep -c -i inferno sqlparser_bench/img/flamegraph.svg
2
```
**Expected behavior**
The source release complies with ASF licensing policy:
1. Add a `NOTICE` file to the repository so it is included in source archives.
2. Exclude the generated `sqlparser_bench/img/flamegraph.svg` from the source release
**Additional context**
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Commencez à la racine du dépôt avec l’archive du code source 0.63.0-rc1 et inspectez NOTICE, LICENSE.TXT et sqlparser_bench/img/flamegraph.svg ; exécutez les vérifications ls et grep de l’issue pour confirmer les constatations. Le travail est terminé lorsque la version source inclut le fichier NOTICE requis et exclut le fichier flamegraph.svg généré sans conserver le JavaScript sous licence CDDL.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- rust
- Domaine
- release
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-2 jours
- Activité
- Active
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 72/100