apache / apache/datafusion-sqlparser-rs

Fix licensing issues in source release found during 0.63.0 RC1 vote (missing NOTICE file, flamegraph.svg with CDDL-licensed JavaScript)

未关闭 适合新手
#2,495 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
3.5k
派生
772
平均合并
4 天 9 小时
30 天内合并 PR
17

描述

**Describe the bug**

During the vote on the Apache DataFusion sqlparser-rs `0.63.0` RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmx

1. **Missing `NOTICE` file**: the source archive contains `LICENSE.TXT` but no `NOTICE` file, which ASF releases are expected to include.
2. **`sqlparser_bench/img/flamegraph.svg` embeds third-party licensed code**: the generated flamegraph embeds JavaScript from [Inferno](https://github.com/jonhoo/inferno), whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.

**To Reproduce**

Download and unpack the 0.63.0 RC1 source archive (or check the repository at `v0.63.0-rc1`):

```shell
$ ls NOTICE*
ls: NOTICE*: No such file or directory

$ grep -c -i inferno sqlparser_bench/img/flamegraph.svg
2
```

**Expected behavior**

The source release complies with ASF licensing policy:

1. Add a `NOTICE` file to the repository so it is included in source archives.
2. Exclude the generated `sqlparser_bench/img/flamegraph.svg` from the source release

**Additional context**

贡献指南

这个仓库没有索引到贡献指南

调研方向

从 repository 根目录开始,使用 0.63.0-rc1 源代码归档并检查 NOTICE、LICENSE.TXT 和 sqlparser_bench/img/flamegraph.svg;运行 issue 中的 ls 和 grep 检查以确认发现。完成的标准是源代码发行版包含所需的 NOTICE 文件,并排除生成的 flamegraph.svg,同时不保留采用 CDDL 许可的 JavaScript。

由索引模型根据 Issue 内容生成。

评估

技术栈
rust
领域
release
Issue 类型
缺陷
难度
2/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
描述清楚
新手友好度
72/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。