apache / apache/datafusion-sqlparser-rs

Create an MSRV policy in this crate

Open
#1,744 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

TLDR woudl be:
1. Define a MSRV policy (maybe copy the existing DataFusion one)
2. Implement some sort of CI check (again can copy / reuse the datafusion one if we want)
3.

🤔 interestingly we don't seem to have an MSRV policy in this crate (at least not that I could find in https://github.com/apache/datafusion-sqlparser-rs/blob/main/README.md)

We do have such a thing in DataFusion here: https://github.com/apache/datafusion?tab=readme-ov-file#rust-version-compatibility-policy

Maybe it is worth considering adding some documentation / policy in the sqlparser crate too 🤔

_Originally posted by @alamb in https://github.com/apache/datafusion-sqlparser-rs/issues/1736#issuecomment-2676808035_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing this crate's README with DataFusion's Rust version compatibility policy, then review the existing DataFusion CI check referenced by the issue. Define the crate's MSRV policy, document it in the README, and add a CI check that enforces the chosen compatibility level.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, documentation
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.