Add option to skip mount of ConfigDrive
- 主要言語
- Java
- スター
- 3.1k
- フォーク
- 1.4k
- 平均マージ
- 6日 19時間
- マージ済み PR(30日)
- 32
説明
##### ISSUE TYPE
* Enhancement Request
##### COMPONENT NAME
~~~
Backend
~~~
##### CLOUDSTACK VERSION
~~~
4.19.1.2
~~~
##### CONFIGURATION
N/A
##### OS / ENVIRONMENT
Ubuntu 22 for Managemente
KVM with Rocky Linux for hypervisor
##### SUMMARY
HI team, I configured a L2 network offering with support for ConfigDrive, becasue i need to use cloudinit to do some tasks.
As per documentation, in this configuration, an iso will be created with ConfigDrive and attached as cdrom to instance.
Moreover with option we can decide to store it on primary or secondary storage.
However, this happen everytime I use at least one network where ConfigDrive is enabled and i don't find a way to "disable" this behaviour apart choice a network with different Offering.
It will be very usefull have a machine settings that can allow us to "disable" mounting the iso, for example after first deployment we can set it ad avoid attach or buil the iso.
##### STEPS TO REPRODUCE
~~~
Create aL2 network offering with Userdata flagged
Create a VM with/without user data
Iso is attached to the vm and mounted (as default) to secondary storage
Remove network with this Network offering
Attach a network with netwokr offering without userdata
VM will not have attached the iso, iso is deleted on secondary
~~~
##### EXPECTED RESULTS
~~~
Add a settings to disable the usage of userdata to vm specific
~~~
##### ACTUAL RESULTS
~~~
No way to disable userdata if is enabled on Network offering
~~~
I think that one pice of code to be modified is this function:
https://github.com/apache/cloudstack/blob/019f2c60ceb7a7c15c670a98280bd5764a5fcf5b/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java#L770-L793
As per system VM, we can add an option to avoid the configuration of ConfigDrive with vm settings.
What do you think team?
コントリビューションガイド
調査の方向性
まず、770~793行付近にあるリンク先の関数の ConfigDriveNetworkElement.java を読み、VM 固有の設定と ConfigDrive のアタッチがどのように表現されているかを追跡します。オプションを使用しない場合の現在のネットワークオファリングの動作を維持したまま、提案された VM ごとのオプションによって ConfigDrive ISO の作成またはアタッチを防止できれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- backend, cloud, infrastructure
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100