apache / apache/cloudstack

Add option to skip mount of ConfigDrive

未關閉
#9,831 0 則留言 2 個 reaction 已指派 0 人 在 GitHub 檢視
type:config
主要語言
Java
星號
3.1k
分支
1.4k
平均合併
6 天 19 小時
30 天內合併 PR
32

描述

##### ISSUE TYPE

* Enhancement Request

##### COMPONENT NAME

~~~
Backend
~~~

##### CLOUDSTACK VERSION

~~~
4.19.1.2
~~~

##### CONFIGURATION

N/A

##### OS / ENVIRONMENT

Ubuntu 22 for Managemente
KVM with Rocky Linux for hypervisor

##### SUMMARY

HI team, I configured a L2 network offering with support for ConfigDrive, becasue i need to use cloudinit to do some tasks.
As per documentation, in this configuration, an iso will be created with ConfigDrive and attached as cdrom to instance.
Moreover with option we can decide to store it on primary or secondary storage.

However, this happen everytime I use at least one network where ConfigDrive is enabled and i don't find a way to "disable" this behaviour apart choice a network with different Offering.

It will be very usefull have a machine settings that can allow us to "disable" mounting the iso, for example after first deployment we can set it ad avoid attach or buil the iso.

##### STEPS TO REPRODUCE

~~~
Create aL2 network offering with Userdata flagged
Create a VM with/without user data
Iso is attached to the vm and mounted (as default) to secondary storage
Remove network with this Network offering
Attach a network with netwokr offering without userdata
VM will not have attached the iso, iso is deleted on secondary
~~~

##### EXPECTED RESULTS

~~~
Add a settings to disable the usage of userdata to vm specific
~~~

##### ACTUAL RESULTS

~~~
No way to disable userdata if is enabled on Network offering
~~~

I think that one pice of code to be modified is this function:
https://github.com/apache/cloudstack/blob/019f2c60ceb7a7c15c670a98280bd5764a5fcf5b/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java#L770-L793

As per system VM, we can add an option to avoid the configuration of ConfigDrive with vm settings.

What do you think team?

貢獻指南

開啟貢獻指南

研究方向

先閱讀連結函式附近第 770-793 行的 ConfigDriveNetworkElement.java,然後追蹤 VM 特定設定和 ConfigDrive 附加是如何表示的。當所提議的每個 VM 選項能夠防止建立或附加 ConfigDrive ISO,同時在未使用該選項時保留目前的網路提供行為,即視為完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
java
領域
backend, cloud, infrastructure
Issue 類型
功能
難度
5/5
預估耗時
一週以上
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。