antirez / antirez/dump1090

Doubt on the symbol decoding function

Aperta
#174 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C
Stelle
2.9k
Fork
1.4k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hello!

I have a question about the following code snipped in the symbol decoding function.

https://github.com/antirez/dump1090/blob/de61bd564f1aa929bae414a70e421acd0b81789a/dump1090.c#L1430-L1448

Is this first condition attempting to solve the same problem as the "outOfPhase" correction? Making it easier to detect sequences of bits with the same value.

If that is the case, then I think the error count is not working as intended, because a `delta` of 0 falls inside the first condition. Hence, it will only count errors on the first bit, before `i>0`. I'm not sure if this implication is taken into account in the rest of the code, it seems to me that it is expecting values greater than 1 in the error count.

Thanks for the clarification!

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.