antirez / antirez/dump1090

Doubt on the symbol decoding function

Open
#174 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
2.9k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

Hello!

I have a question about the following code snipped in the symbol decoding function.

https://github.com/antirez/dump1090/blob/de61bd564f1aa929bae414a70e421acd0b81789a/dump1090.c#L1430-L1448

Is this first condition attempting to solve the same problem as the "outOfPhase" correction? Making it easier to detect sequences of bits with the same value.

If that is the case, then I think the error count is not working as intended, because a `delta` of 0 falls inside the first condition. Hence, it will only count errors on the first bit, before `i>0`. I'm not sure if this implication is taken into account in the rest of the code, it seems to me that it is expecting values greater than 1 in the error count.

Thanks for the clarification!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.