antirez / antirez/dump1090

Doubt on the symbol decoding function

Offen
#174 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
C
Sterne
2.9k
Forks
1.4k
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Hello!

I have a question about the following code snipped in the symbol decoding function.

https://github.com/antirez/dump1090/blob/de61bd564f1aa929bae414a70e421acd0b81789a/dump1090.c#L1430-L1448

Is this first condition attempting to solve the same problem as the "outOfPhase" correction? Making it easier to detect sequences of bits with the same value.

If that is the case, then I think the error count is not working as intended, because a `delta` of 0 falls inside the first condition. Hence, it will only count errors on the first bit, before `i>0`. I'm not sure if this implication is taken into account in the rest of the code, it seems to me that it is expecting values greater than 1 in the error count.

Thanks for the clarification!

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.