antirez / antirez/dump1090

Doubt on the symbol decoding function

未關閉
#174 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
C
星號
2.9k
分支
1.4k
PR 合併指標
30 天內沒有已合併 PR

描述

Hello!

I have a question about the following code snipped in the symbol decoding function.

https://github.com/antirez/dump1090/blob/de61bd564f1aa929bae414a70e421acd0b81789a/dump1090.c#L1430-L1448

Is this first condition attempting to solve the same problem as the "outOfPhase" correction? Making it easier to detect sequences of bits with the same value.

If that is the case, then I think the error count is not working as intended, because a `delta` of 0 falls inside the first condition. Hence, it will only count errors on the first bit, before `i>0`. I'm not sure if this implication is taken into account in the rest of the code, it seems to me that it is expecting values greater than 1 in the error count.

Thanks for the clarification!

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。