ankidroid / ankidroid/Anki-Android

The GA4 Measurement Protocol key

Đang mở
#21,026 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
Analytics Keep Open
Ngôn ngữ chính
Kotlin
Star
11.8k
Fork
2.9k
Merge trung bình
2 ngày 3 giờ
Pull request đã merge (30 ngày)
171

Mô tả

### Context
The GA4 Measurement Protocol `api_secret` is currently sourced from `local.properties` (`ANALYTICS_API_KEY`) or the `ANALYTICS_API_KEY` env var, with a `DUMMY_API_XXX` fallback so contributor builds compile.

### Question raised by @david-allison
> Only an issue with the build.gradle change, and that's mostly my ignorance/wanting reassurance.
>
> I believe in our prior implementation, the key wasn't obscured. Obscuring a publicly-facing analytics key is
> semi-understandable from the perspective of not wanting malicious clients, but it's unusual to me, as it's not a > private key.
>
> (For example, with Firebase, this would be a public credential on a website)
>
> If you'd be OK with deferring the conversation, shift it to an issue and merge at will!
> cc @mikehardy

### TODO
- [ ] Research how other OSS Android projects handle GA4 Measurement Protocol `api_secret` (Signal, K-9 Mail, F-Droid clients, etc.)
- [ ] Decide: keep obscuring, publish the key, or stand up a separate dev GA4 property
- [ ] Document the decision in the analytics package KDoc

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.