ankidroid / ankidroid/Anki-Android

The GA4 Measurement Protocol key

オープン
#21,026 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
Analytics Keep Open
主要言語
Kotlin
スター
11.8k
フォーク
2.9k
平均マージ
2日 3時間
マージ済み PR(30日)
171

説明

### Context
The GA4 Measurement Protocol `api_secret` is currently sourced from `local.properties` (`ANALYTICS_API_KEY`) or the `ANALYTICS_API_KEY` env var, with a `DUMMY_API_XXX` fallback so contributor builds compile.

### Question raised by @david-allison
> Only an issue with the build.gradle change, and that's mostly my ignorance/wanting reassurance.
>
> I believe in our prior implementation, the key wasn't obscured. Obscuring a publicly-facing analytics key is
> semi-understandable from the perspective of not wanting malicious clients, but it's unusual to me, as it's not a > private key.
>
> (For example, with Firebase, this would be a public credential on a website)
>
> If you'd be OK with deferring the conversation, shift it to an issue and merge at will!
> cc @mikehardy

### TODO
- [ ] Research how other OSS Android projects handle GA4 Measurement Protocol `api_secret` (Signal, K-9 Mail, F-Droid clients, etc.)
- [ ] Decide: keep obscuring, publish the key, or stand up a separate dev GA4 property
- [ ] Document the decision in the analytics package KDoc

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。