angular / angular/components

bug(many): duplicate code for exposing overlays for modals

オープン
#26,853 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
Accessibility area: many P4 refactoring
主要言語
TypeScript
スター
25k
フォーク
6.8k
平均マージ
1日 8時間
マージ済み PR(30日)
91

説明

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

We have duplicated code for logic for exposing overlays to modals. some browsers won't expose the accessibility node of the overlay if there is an `aria-modal` and the live element is outside of it. This method works around the issue by pointing the `aria-owns` of all modals to the live element.

Action item to consider de-duplicating this with the `LiveAnnouncer` and any other occurrences.

Note that the selector here is limited to CDK overlays at the moment in order to reduce the section of the DOM we need to look through. This should cover all the cases we support, but the selector can be expanded if it turns out to be too narrow.

### Reproduction

Search codebase for TODOS references this issue report.

```
git grep 'TODO(http://github.com/angular/components/issues/26853)'; git grep '#26853';
```

### Expected Behavior

no occurrences

### Actual Behavior

multiple occurrences

### Environment

N/A

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Run the two git grep commands from the issue to locate every TODO reference to #26853, then read the surrounding overlay and LiveAnnouncer logic. Consolidate the duplicated overlay-exposure handling without changing supported CDK overlay behavior; done means both searches return no occurrences and the relevant tests pass.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
accessibility, frontend
issue の種類
リファクタリング
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
48/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。