angular / angular/components

bug(many): duplicate code for exposing overlays for modals

Ouverte
#26,853 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Accessibility area: many P4 refactoring
Langage dominant
TypeScript
Étoiles
25k
Forks
6.8k
Merge moyen
1 j 8 h
PR mergées (30 j)
91

Description

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

We have duplicated code for logic for exposing overlays to modals. some browsers won't expose the accessibility node of the overlay if there is an `aria-modal` and the live element is outside of it. This method works around the issue by pointing the `aria-owns` of all modals to the live element.

Action item to consider de-duplicating this with the `LiveAnnouncer` and any other occurrences.

Note that the selector here is limited to CDK overlays at the moment in order to reduce the section of the DOM we need to look through. This should cover all the cases we support, but the selector can be expanded if it turns out to be too narrow.

### Reproduction

Search codebase for TODOS references this issue report.

```
git grep 'TODO(http://github.com/angular/components/issues/26853)'; git grep '#26853';
```

### Expected Behavior

no occurrences

### Actual Behavior

multiple occurrences

### Environment

N/A

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Run the two git grep commands from the issue to locate every TODO reference to #26853, then read the surrounding overlay and LiveAnnouncer logic. Consolidate the duplicated overlay-exposure handling without changing supported CDK overlay behavior; done means both searches return no occurrences and the relevant tests pass.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
typescript
Domaine
accessibility, frontend
Type d'issue
Refactorisation
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.