respect wepack export condition for importing
- Langage dominant
- TypeScript
- Étoiles
- 27k
- Forks
- 11.8k
- Merge moyen
- 14 h 23 min
- PR mergées (30 j)
- 162
Description
### Command
build, extract-i18n, serve, test
### Description
The root problem I am trying to solve is the different import behavior of esbuild and webpack for url resources like described here ( https://github.com/angular/angular-cli/issues/24470 ).
We have a npm package shipping company fonts and scss file to import them.
I know that there are other possibilities, but I also discovered that we could have different entrypoints for webpack and esbuild
when using conditions in the package.json as described here: https://webpack.js.org/guides/package-exports/#conditions-preprocessor-and-runtimes.
This was leading me to this package.json
```json
"exports": {
"./styles/*": {
"webpack": {
"sass": "./dist/styles/webpack/*.scss",
"less": "./dist/styles/webpack/*.less",
"style": "./dist/styles/webpack/*.css"
},
"sass": "./dist/styles/*.scss",
"less": "./dist/styles/*.less",
"style": "./dist/styles/*.css"
},
"./*": "./dist/fonts/*"
}
```
The only problem here is, that this does not work. Webpack is loading the normal sass styles.
### Describe the solution you'd like
It would be really cool if the webpack condition is matched.
### Describe alternatives you've considered
We could offer a scss variable so that consumers can override the font path or just casually export the file. This still does not solve the problem when using esbuild and the karma runner but at least they could do something.
I am not sure how much effort it is fixing this, but in case you just need to add `webpack` here: https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/tools/webpack/configs/styles.ts#L382 it would be really cool if you could do it.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez dans packages/angular_devkit/build_angular/src/tools/webpack/configs/styles.ts vers la ligne 382 et suivez la manière dont les imports de styles résolvent les conditions d’exportation des packages. Exécutez les commandes build, extract-i18n, serve et test avec l’exemple de package ; le travail est terminé lorsque webpack sélectionne sa condition et que la résolution existante de sass, less et style continue de fonctionner.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- sass, scss, typescript, webpack
- Domaine
- build-system, tooling
- Type d'issue
- Fonctionnalité
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100