respect wepack export condition for importing
- Vorherrschende Sprache
- TypeScript
- Sterne
- 27k
- Forks
- 11.8k
- Ø Merge
- 14 Std. 23 Min.
- Gemergte PRs (30 T.)
- 162
Beschreibung
### Command
build, extract-i18n, serve, test
### Description
The root problem I am trying to solve is the different import behavior of esbuild and webpack for url resources like described here ( https://github.com/angular/angular-cli/issues/24470 ).
We have a npm package shipping company fonts and scss file to import them.
I know that there are other possibilities, but I also discovered that we could have different entrypoints for webpack and esbuild
when using conditions in the package.json as described here: https://webpack.js.org/guides/package-exports/#conditions-preprocessor-and-runtimes.
This was leading me to this package.json
```json
"exports": {
"./styles/*": {
"webpack": {
"sass": "./dist/styles/webpack/*.scss",
"less": "./dist/styles/webpack/*.less",
"style": "./dist/styles/webpack/*.css"
},
"sass": "./dist/styles/*.scss",
"less": "./dist/styles/*.less",
"style": "./dist/styles/*.css"
},
"./*": "./dist/fonts/*"
}
```
The only problem here is, that this does not work. Webpack is loading the normal sass styles.
### Describe the solution you'd like
It would be really cool if the webpack condition is matched.
### Describe alternatives you've considered
We could offer a scss variable so that consumers can override the font path or just casually export the file. This still does not solve the problem when using esbuild and the karma runner but at least they could do something.
I am not sure how much effort it is fixing this, but in case you just need to add `webpack` here: https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/tools/webpack/configs/styles.ts#L382 it would be really cool if you could do it.
Beitragsleitfaden
Rechercherichtung
Beginnen Sie bei packages/angular_devkit/build_angular/src/tools/webpack/configs/styles.ts ungefähr bei Zeile 382 und verfolgen Sie, wie Style-Imports die Exportbedingungen von Paketen auflösen. Führen Sie die Befehle build, extract-i18n, serve und test mit dem Paketbeispiel aus; als abgeschlossen gilt die Aufgabe, wenn webpack seine Bedingung auswählt und die bestehende Auflösung von sass, less und style weiterhin funktioniert.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- sass, scss, typescript, webpack
- Bereich
- build-system, tooling
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100