angular / angular/angular-cli

Template type checking re-builds do not run correctly when referencing a re-exported type

Aberta
#21,757 3 comentários 0 reações 0 responsáveis Ver no GitHub
area: @ngtools/webpack needs: investigation
Linguagem predominante
TypeScript
Estrelas
27k
Forks
11.8k
Merge médio
14h 23min
PRs com merge (30d)
162

Descrição

### Which @angular/* package(s) are the source of the bug?

Don't known / other

### Is this a regression?

Yes

### Description

Consider the following example, running ng serve with template type checking turned on:

- An Angular template references a property on the component class in an expression.
- This component class properties type definition comes from a file which re-exports the type definition from another file.
- Re-builds do not always re-compile the template expression when they should.

More specifically, in the reproduction repo this looks as follows:

- The app component template includes an expression: `{{ myType?.abc }}`.
- The app component class defines the myType property: `myType?: MyTypeReExported`.
- The type of the myType property comes from a file which re-exports another type. `export type MyTypeRexported = MyType`.
- The type MyType comes from a file which defines the definition as: `export interface MyType { abc: 123; }`.
- The initial ng serve will run without errors.
- Changing the type definition of MyType to be `export interface MyType { abcd: 123; }` causes an error in the app component's template. This is seen in the re-build console output. This is the correct behaviour.
- Changing the type definition back to what it was originally should remove the error. However, it does not. That is the bug.

### Please provide a link to a minimal reproduction of the bug

https://github.com/HazzMan2409/angular-template-rebuild-bug

### Please provide the environment you discovered this bug in

```true
Angular 12.2.5.
Node 14.17.6

See the package.json on the repo for more details. At the time 12.2.5 was the latest version.
```

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Comece com a reprodução mínima vinculada e execute ng serve com a verificação de tipos de template habilitada nas versões de Angular e Node indicadas. Altere MyType entre as definições abc e abcd e, em seguida, inspecione os caminhos de rebuild do Angular CLI e de verificação de tipos de template. Está concluído quando reverter a definição de tipo remove o erro do template no rebuild.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
angular, typescript
Domínio
build-system
Tipo de issue
Bug
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
35/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.