angular / angular/angular-cli

Template type checking re-builds do not run correctly when referencing a re-exported type

Abierto
#21,757 3 comentarios 0 reacciones 0 asignados Ver en GitHub
area: @ngtools/webpack needs: investigation
Lenguaje dominante
TypeScript
Estrellas
27k
Forks
11.8k
Merge medio
14 h 23 min
PR fusionados (30 d)
162

Descripción

### Which @angular/* package(s) are the source of the bug?

Don't known / other

### Is this a regression?

Yes

### Description

Consider the following example, running ng serve with template type checking turned on:

- An Angular template references a property on the component class in an expression.
- This component class properties type definition comes from a file which re-exports the type definition from another file.
- Re-builds do not always re-compile the template expression when they should.

More specifically, in the reproduction repo this looks as follows:

- The app component template includes an expression: `{{ myType?.abc }}`.
- The app component class defines the myType property: `myType?: MyTypeReExported`.
- The type of the myType property comes from a file which re-exports another type. `export type MyTypeRexported = MyType`.
- The type MyType comes from a file which defines the definition as: `export interface MyType { abc: 123; }`.
- The initial ng serve will run without errors.
- Changing the type definition of MyType to be `export interface MyType { abcd: 123; }` causes an error in the app component's template. This is seen in the re-build console output. This is the correct behaviour.
- Changing the type definition back to what it was originally should remove the error. However, it does not. That is the bug.

### Please provide a link to a minimal reproduction of the bug

https://github.com/HazzMan2409/angular-template-rebuild-bug

### Please provide the environment you discovered this bug in

```true
Angular 12.2.5.
Node 14.17.6

See the package.json on the repo for more details. At the time 12.2.5 was the latest version.
```

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza con la reproducción mínima enlazada y ejecuta ng serve con la comprobación de tipos de plantillas habilitada en las versiones de Angular y Node indicadas. Cambia MyType entre las definiciones abc y abcd y, a continuación, inspecciona las rutas de reconstrucción de Angular CLI y de comprobación de tipos de plantillas. Se considera terminado cuando revertir la definición de tipo elimina el error de la plantilla durante la reconstrucción.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
build-system
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.