android10 / android10/Android-CleanArchitecture-Kotlin

Domain separated from Feature, is it a good idea?

未關閉
#23 10 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
discussion question
主要語言
Kotlin
星號
4.8k
分支
929
PR 合併指標
30 天內沒有已合併 PR

描述

Hey all,
I've seen [entities](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieEntity.kt) and
[repositories](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesRepository.kt) defined inside the feature, and I thought at first that it is not ideal. Why?
Because it will be used in other modules (features) and failing at the principle of isolation.
So I did what the [_core_](https://github.com/android10/Android-CleanArchitecture-Kotlin/tree/master/app/src/main/kotlin/com/fernandocejas/sample/core) package did, I've made a data package for the whole app to use all entities, repositories, etc.
![2018-05-23 17_12_48-irrisimples-android c__users_std1_documents_projetos_std1_irriplus_irrisimples_](https://user-images.githubusercontent.com/7623967/40448678-962ad024-5eac-11e8-94a6-71365d2e43b4.png)
What do you guys think of this? Pros and cons?

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。