android10 / android10/Android-CleanArchitecture-Kotlin

Domain separated from Feature, is it a good idea?

Aberta
#23 10 comentários 1 reação 0 responsáveis Ver no GitHub
discussion question
Linguagem predominante
Kotlin
Estrelas
4.8k
Forks
929
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Hey all,
I've seen [entities](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieEntity.kt) and
[repositories](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesRepository.kt) defined inside the feature, and I thought at first that it is not ideal. Why?
Because it will be used in other modules (features) and failing at the principle of isolation.
So I did what the [_core_](https://github.com/android10/Android-CleanArchitecture-Kotlin/tree/master/app/src/main/kotlin/com/fernandocejas/sample/core) package did, I've made a data package for the whole app to use all entities, repositories, etc.
![2018-05-23 17_12_48-irrisimples-android c__users_std1_documents_projetos_std1_irriplus_irrisimples_](https://user-images.githubusercontent.com/7623967/40448678-962ad024-5eac-11e8-94a6-71365d2e43b4.png)
What do you guys think of this? Pros and cons?

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.