android10 / android10/Android-CleanArchitecture-Kotlin

Domain separated from Feature, is it a good idea?

Aperta
#23 10 commenti 1 reazione 0 assegnatari Vedi su GitHub
discussion question
Lingua principale
Kotlin
Stelle
4.8k
Fork
929
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hey all,
I've seen [entities](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieEntity.kt) and
[repositories](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesRepository.kt) defined inside the feature, and I thought at first that it is not ideal. Why?
Because it will be used in other modules (features) and failing at the principle of isolation.
So I did what the [_core_](https://github.com/android10/Android-CleanArchitecture-Kotlin/tree/master/app/src/main/kotlin/com/fernandocejas/sample/core) package did, I've made a data package for the whole app to use all entities, repositories, etc.
![2018-05-23 17_12_48-irrisimples-android c__users_std1_documents_projetos_std1_irriplus_irrisimples_](https://user-images.githubusercontent.com/7623967/40448678-962ad024-5eac-11e8-94a6-71365d2e43b4.png)
What do you guys think of this? Pros and cons?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.