android10 / android10/Android-CleanArchitecture-Kotlin

Domain separated from Feature, is it a good idea?

Ouverte
#23 10 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
discussion question
Langage dominant
Kotlin
Étoiles
4.8k
Forks
929
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Hey all,
I've seen [entities](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieEntity.kt) and
[repositories](https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesRepository.kt) defined inside the feature, and I thought at first that it is not ideal. Why?
Because it will be used in other modules (features) and failing at the principle of isolation.
So I did what the [_core_](https://github.com/android10/Android-CleanArchitecture-Kotlin/tree/master/app/src/main/kotlin/com/fernandocejas/sample/core) package did, I've made a data package for the whole app to use all entities, repositories, etc.
![2018-05-23 17_12_48-irrisimples-android c__users_std1_documents_projetos_std1_irriplus_irrisimples_](https://user-images.githubusercontent.com/7623967/40448678-962ad024-5eac-11e8-94a6-71365d2e43b4.png)
What do you guys think of this? Pros and cons?

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.