amplitude / amplitude/experiment-react-native-client

Move types to @amplitude/experiment-core

未關閉
#46 0 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
8
分支
6
PR 合併指標
30 天內沒有已合併 PR

描述

Hi team,

Would it be possible to merge duplicate core types such as `client.d.ts`, `variant.d.ts`, and other types from these two packages:
- `@amplitude/experiment-react-native-client/lib/typescript/types/*`
- `@amplitude/experiment-js-client/dist/types/src/types/*`

... into `@amplitude/experiment-core` ?

Typing the ExperimentClient either from the Web type **OR** the React Native type seems like a bit of a shame when it seems they're pretty much the same?

I'm implementing a Provider that's meant to be common, both to our React web app + and our two React Native apps, both using typescript on a monorepo. My Provider is supposed to receive an `ExperimentClient`, either instantiated from `@amplitude/experiment-react-native-client` or `@amplitude/experiment-js-client` 🙏

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。