amplitude / amplitude/experiment-react-native-client

Move types to @amplitude/experiment-core

Aberta
#46 0 comentários 1 reação 0 responsáveis Ver no GitHub
Linguagem predominante
TypeScript
Estrelas
8
Forks
6
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Hi team,

Would it be possible to merge duplicate core types such as `client.d.ts`, `variant.d.ts`, and other types from these two packages:
- `@amplitude/experiment-react-native-client/lib/typescript/types/*`
- `@amplitude/experiment-js-client/dist/types/src/types/*`

... into `@amplitude/experiment-core` ?

Typing the ExperimentClient either from the Web type **OR** the React Native type seems like a bit of a shame when it seems they're pretty much the same?

I'm implementing a Provider that's meant to be common, both to our React web app + and our two React Native apps, both using typescript on a monorepo. My Provider is supposed to receive an `ExperimentClient`, either instantiated from `@amplitude/experiment-react-native-client` or `@amplitude/experiment-js-client` 🙏

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.