amplitude / amplitude/experiment-react-native-client

Move types to @amplitude/experiment-core

未关闭
#46 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
8
派生
6
PR 合并指标
30 天内没有已合并 PR

描述

Hi team,

Would it be possible to merge duplicate core types such as `client.d.ts`, `variant.d.ts`, and other types from these two packages:
- `@amplitude/experiment-react-native-client/lib/typescript/types/*`
- `@amplitude/experiment-js-client/dist/types/src/types/*`

... into `@amplitude/experiment-core` ?

Typing the ExperimentClient either from the Web type **OR** the React Native type seems like a bit of a shame when it seems they're pretty much the same?

I'm implementing a Provider that's meant to be common, both to our React web app + and our two React Native apps, both using typescript on a monorepo. My Provider is supposed to receive an `ExperimentClient`, either instantiated from `@amplitude/experiment-react-native-client` or `@amplitude/experiment-js-client` 🙏

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。