algolia / algolia/algoliasearch-client-java

Handle `autoGenerateObjectIDIfNotExist` parameter for `replaceAllObjects()` method

Open
#666 0 comments 0 reactions 0 assignees View on GitHub
Good First Issue
Dominant language
Java
Stars
52
Forks
33
PR merge metrics
No merged PRs in 30d

Description

The `autoGenerateObjectIDIfNotExist` boolean parameter is for now only valid in
the context of the `saveObjects()` method. As pointed out by @julienpa, it would
make sense to also accepts it as a valid parameter of `replaceAllObjects()`.

For backward-compatiblity, let's make sure the default behavior of calling
`replaceAllObjects()` without the `autoGenerateObjectIDIfNotExist` parameter is
still considered as if it was set to `false`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the replaceAllObjects() and saveObjects() method definitions in the Java client and compare how the parameter is currently handled. Verify that replaceAllObjects() accepts the boolean while calls that omit it retain the false behavior; add or update coverage for both invocation forms if matching tests are present.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.