akiran / akiran/react-slick

current slide incorrect value when infinite=false and slidesToShow > 1

Aperta
#1,809 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
11.9k
Fork
2.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

When multiple slides are shown and that the slider cannot move left anymore, the current slide index does not change.

It seems that the state change that triggers animation uses the slide index to make the animation, and so does not change the value when animation is not possible. This is incorrect behaviour, as the clicked slide should be the current one, and not the leftmost visible slide.

This is a problem when using a thumbnail slider asNavFor a larger slider, as it makes it impossible to highlight the currently selected slide.

This affect the slick-current css class, as well as the beforeChange and afterChange events.

Example here [CodeSandBox](https://codesandbox.io/embed/react-slick-playground-11rg7?fontsize=14&hidenavigation=1&theme=dark). To replicate, navigate to the last slides and click on any of the last ones. The red border is on .slick-current.

This probably also causes [1541](https://github.com/akiran/react-slick/issues/1541)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.