akiran / akiran/react-slick

current slide incorrect value when infinite=false and slidesToShow > 1

Open
#1,809 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11.9k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

When multiple slides are shown and that the slider cannot move left anymore, the current slide index does not change.

It seems that the state change that triggers animation uses the slide index to make the animation, and so does not change the value when animation is not possible. This is incorrect behaviour, as the clicked slide should be the current one, and not the leftmost visible slide.

This is a problem when using a thumbnail slider asNavFor a larger slider, as it makes it impossible to highlight the currently selected slide.

This affect the slick-current css class, as well as the beforeChange and afterChange events.

Example here [CodeSandBox](https://codesandbox.io/embed/react-slick-playground-11rg7?fontsize=14&hidenavigation=1&theme=dark). To replicate, navigate to the last slides and click on any of the last ones. The red border is on .slick-current.

This probably also causes [1541](https://github.com/akiran/react-slick/issues/1541)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.