akiran / akiran/react-slick

current slide incorrect value when infinite=false and slidesToShow > 1

Abierto
#1,809 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
11.9k
Forks
2.1k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

When multiple slides are shown and that the slider cannot move left anymore, the current slide index does not change.

It seems that the state change that triggers animation uses the slide index to make the animation, and so does not change the value when animation is not possible. This is incorrect behaviour, as the clicked slide should be the current one, and not the leftmost visible slide.

This is a problem when using a thumbnail slider asNavFor a larger slider, as it makes it impossible to highlight the currently selected slide.

This affect the slick-current css class, as well as the beforeChange and afterChange events.

Example here [CodeSandBox](https://codesandbox.io/embed/react-slick-playground-11rg7?fontsize=14&hidenavigation=1&theme=dark). To replicate, navigate to the last slides and click on any of the last ones. The red border is on .slick-current.

This probably also causes [1541](https://github.com/akiran/react-slick/issues/1541)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.