akiran / akiran/react-foundation-apps

Parent component setState events not triggering tab content re-renders

Aperta
#17 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
291
Fork
45
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I have a page like this:

```
React.createClass({
onChange: function() {
this.setState({
customer: CustomerStore.getCustomer()
})
},

...

render: function() {
return (










)
}
})
```

If I update the CustomerStore with a customer (say via an asynchronous request), it
will not trigger the tab content components to re-render.

I believe that is due to the `cloneWithProps` call (https://github.com/akiran/react-foundation-apps/blob/master/lib/tabs/index.jsx#L16).

Incidentally, cloneWithProps is now deprecated and it should be `React.cloneElement`. I'm not able to
make it work even by using that `cloneElement`, though. I can think of a few workarounds but they all seem
terrible.

Any ideas?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.