akiran / akiran/react-foundation-apps

Parent component setState events not triggering tab content re-renders

Abierto
#17 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
291
Forks
45
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I have a page like this:

```
React.createClass({
onChange: function() {
this.setState({
customer: CustomerStore.getCustomer()
})
},

...

render: function() {
return (










)
}
})
```

If I update the CustomerStore with a customer (say via an asynchronous request), it
will not trigger the tab content components to re-render.

I believe that is due to the `cloneWithProps` call (https://github.com/akiran/react-foundation-apps/blob/master/lib/tabs/index.jsx#L16).

Incidentally, cloneWithProps is now deprecated and it should be `React.cloneElement`. I'm not able to
make it work even by using that `cloneElement`, though. I can think of a few workarounds but they all seem
terrible.

Any ideas?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.