akiran / akiran/react-foundation-apps
Parent component setState events not triggering tab content re-renders
- Dominant language
- JavaScript
- Stars
- 291
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
I have a page like this:
```
React.createClass({
onChange: function() {
this.setState({
customer: CustomerStore.getCustomer()
})
},
...
render: function() {
return (
)
}
})
```
If I update the CustomerStore with a customer (say via an asynchronous request), it
will not trigger the tab content components to re-render.
I believe that is due to the `cloneWithProps` call (https://github.com/akiran/react-foundation-apps/blob/master/lib/tabs/index.jsx#L16).
Incidentally, cloneWithProps is now deprecated and it should be `React.cloneElement`. I'm not able to
make it work even by using that `cloneElement`, though. I can think of a few workarounds but they all seem
terrible.
Any ideas?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.