airvzxf / airvzxf/ftp-deployment-action

chore(release): re-enabling ECR Public requires coordinated changes in 4 sites, no end-to-end test

オープン
#212 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
audit chore pending-aws pending-human priority:high
主要言語
Shell
スター
37
フォーク
9
平均マージ
44分
マージ済み PR(30日)
47

説明

gh issue create --title "chore(release): re-enabling ECR Public requires coordinated changes in 4 sites, no end-to-end test" --label "chore,audit,priority:high" --body "## Finding

ECR Public publishing is currently disabled (commented out). Re-enabling requires changes in at least 4 places in release.yml:
1. The build job's push step (login to ECR Public).
2. The verify-tags / publish-images matrix.
3. The cosign signing step (different OIDC audience?).
4. The CycloneDX SBOM attestation target.

There is no end-to-end test that exercises the ECR Public path; only the ghcr.io path is exercised by the contract test.

## Affected code

- .github/workflows/release.yml — ECR Public publishing sites

## Reproduction

N/A — code review.

## Suggested fix

Either:
- Document the re-enable procedure in AGENTS.md / docs/release.md.
- Or remove the dead code (commented-out ECR sections) entirely.

The first option is preferred because the ECR path was deliberately scaffolded for future use.

## Source

F2 audit 2026-09-03 (workflows audit). Reporter: subagent-pekodbj7.

## Related

- Part of EPIC #[epic-number]
- Closes: #NONE (no existing issue)
- Related: M4 (ECR Public attestation is dead code), M5 (dockerhub_image / ecr_image referenced before guard)"

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

Start with .github/workflows/release.yml and inspect all four commented ECR Public sites, then compare them with the working ghcr.io path and its contract test. Check AGENTS.md and docs/release.md for the appropriate place to record the procedure. Done means the coordinated ECR path is either documented for future re-enablement or its dead sections are intentionally removed, with the chosen outcome covering the missing end-to-end-test concern.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
aws, github-actions
領域
ci-cd, cloud, release
issue の種類
ドキュメント
難易度
4/5
見積もり時間
3〜5日
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
42/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。