airvzxf / airvzxf/ftp-deployment-action

chore(release): re-enabling ECR Public requires coordinated changes in 4 sites, no end-to-end test

Ouverte
#212 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
audit chore pending-aws pending-human priority:high
Langage dominant
Shell
Étoiles
37
Forks
9
Merge moyen
44 min
PR mergées (30 j)
47

Description

gh issue create --title "chore(release): re-enabling ECR Public requires coordinated changes in 4 sites, no end-to-end test" --label "chore,audit,priority:high" --body "## Finding

ECR Public publishing is currently disabled (commented out). Re-enabling requires changes in at least 4 places in release.yml:
1. The build job's push step (login to ECR Public).
2. The verify-tags / publish-images matrix.
3. The cosign signing step (different OIDC audience?).
4. The CycloneDX SBOM attestation target.

There is no end-to-end test that exercises the ECR Public path; only the ghcr.io path is exercised by the contract test.

## Affected code

- .github/workflows/release.yml — ECR Public publishing sites

## Reproduction

N/A — code review.

## Suggested fix

Either:
- Document the re-enable procedure in AGENTS.md / docs/release.md.
- Or remove the dead code (commented-out ECR sections) entirely.

The first option is preferred because the ECR path was deliberately scaffolded for future use.

## Source

F2 audit 2026-09-03 (workflows audit). Reporter: subagent-pekodbj7.

## Related

- Part of EPIC #[epic-number]
- Closes: #NONE (no existing issue)
- Related: M4 (ECR Public attestation is dead code), M5 (dockerhub_image / ecr_image referenced before guard)"

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start with .github/workflows/release.yml and inspect all four commented ECR Public sites, then compare them with the working ghcr.io path and its contract test. Check AGENTS.md and docs/release.md for the appropriate place to record the procedure. Done means the coordinated ECR path is either documented for future re-enablement or its dead sections are intentionally removed, with the chosen outcome covering the missing end-to-end-test concern.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
aws, github-actions
Domaine
ci-cd, cloud, release
Type d'issue
Documentation
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
42/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.