airbytehq / airbytehq/PyAirbyte

Evaluate adding workspace validation to CloudSource and CloudDestination

未关闭
#930 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
344
派生
77
平均合并
1 天 11 小时
30 天内合并 PR
35

描述

## Summary

Following the addition of workspace validation to `CloudConnection` in https://github.com/airbytehq/PyAirbyte/pull/929, we should evaluate whether similar validation should be added to `CloudSource` and `CloudDestination` classes.

## Background

PR #929 added:
- `check_is_valid()` method to `CloudConnection` to verify the connection exists and belongs to the expected workspace
- `AirbyteWorkspaceMismatchError` exception (generic, designed to work with connections, sources, and destinations)
- Updated `_fetch_connection_info()` with `force_refresh` and `verify` parameters

The exception was intentionally designed to be generic (with `resource_type` and `resource_id` fields) to support future use with sources and destinations.

## Proposed Work

1. Evaluate if `CloudSource` and `CloudDestination` classes would benefit from similar `check_is_valid()` methods
2. If so, implement workspace validation using the existing `AirbyteWorkspaceMismatchError` exception
3. Update `_fetch_connector_info()` methods with similar `force_refresh` and `verify` parameters

## Timeline

Evaluate after ~1 month of usage to gather feedback on the `CloudConnection` implementation.

---
Requested by @aaronsteers

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。