airbytehq / airbytehq/PyAirbyte
Evaluate adding workspace validation to CloudSource and CloudDestination
- Langage dominant
- Python
- Étoiles
- 344
- Forks
- 77
- Merge moyen
- 1 j 11 h
- PR mergées (30 j)
- 35
Description
## Summary
Following the addition of workspace validation to `CloudConnection` in https://github.com/airbytehq/PyAirbyte/pull/929, we should evaluate whether similar validation should be added to `CloudSource` and `CloudDestination` classes.
## Background
PR #929 added:
- `check_is_valid()` method to `CloudConnection` to verify the connection exists and belongs to the expected workspace
- `AirbyteWorkspaceMismatchError` exception (generic, designed to work with connections, sources, and destinations)
- Updated `_fetch_connection_info()` with `force_refresh` and `verify` parameters
The exception was intentionally designed to be generic (with `resource_type` and `resource_id` fields) to support future use with sources and destinations.
## Proposed Work
1. Evaluate if `CloudSource` and `CloudDestination` classes would benefit from similar `check_is_valid()` methods
2. If so, implement workspace validation using the existing `AirbyteWorkspaceMismatchError` exception
3. Update `_fetch_connector_info()` methods with similar `force_refresh` and `verify` parameters
## Timeline
Evaluate after ~1 month of usage to gather feedback on the `CloudConnection` implementation.
---
Requested by @aaronsteers
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.