airbytehq / airbytehq/PyAirbyte

Evaluate adding workspace validation to CloudSource and CloudDestination

Aperta
#930 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
344
Fork
77
Merge medio
1g 11h
PR unite (30g)
35

Descrizione

## Summary

Following the addition of workspace validation to `CloudConnection` in https://github.com/airbytehq/PyAirbyte/pull/929, we should evaluate whether similar validation should be added to `CloudSource` and `CloudDestination` classes.

## Background

PR #929 added:
- `check_is_valid()` method to `CloudConnection` to verify the connection exists and belongs to the expected workspace
- `AirbyteWorkspaceMismatchError` exception (generic, designed to work with connections, sources, and destinations)
- Updated `_fetch_connection_info()` with `force_refresh` and `verify` parameters

The exception was intentionally designed to be generic (with `resource_type` and `resource_id` fields) to support future use with sources and destinations.

## Proposed Work

1. Evaluate if `CloudSource` and `CloudDestination` classes would benefit from similar `check_is_valid()` methods
2. If so, implement workspace validation using the existing `AirbyteWorkspaceMismatchError` exception
3. Update `_fetch_connector_info()` methods with similar `force_refresh` and `verify` parameters

## Timeline

Evaluate after ~1 month of usage to gather feedback on the `CloudConnection` implementation.

---
Requested by @aaronsteers

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.