aio-libs / aio-libs/aiohttp

[Discussion] Ordering of middlewares=

Ouverte
#6,798 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Python
Étoiles
16.5k
Forks
2.4k
Merge moyen
17 h 22 min
PR mergées (30 j)
212

Description

### Describe the bug

Some users try to use `Application(middlewares=...)` and then use the `setup()` functions from other libraries, which add their own middlewares.

This can cause problems due to the ordering of middlewares. I suspect that passing a list of middlewares like this makes users less aware of the ordering of middlewares at the end of their setup.

Maybe we should consider disallowing the passing of middlewares and require later `app.middlewares.append()` etc.?

Or, lock the middlewares when they have been passed in, such that it can't be mixed with `.append()` or `setup()`. This allows a user to pass a fixed sequence of middlewares that will never change. If they need to use `setup()` or similar, then they must add all their middlewares as a separate step, paying attention to what order to add them along with the `setup()` calls.

### Additional context

#6789

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.