aio-libs / aio-libs/aiohttp

[Discussion] Ordering of middlewares=

Offen
#6,798 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
Python
Sterne
16.5k
Forks
2.4k
Ø Merge
17 Std. 22 Min.
Gemergte PRs (30 T.)
212

Beschreibung

### Describe the bug

Some users try to use `Application(middlewares=...)` and then use the `setup()` functions from other libraries, which add their own middlewares.

This can cause problems due to the ordering of middlewares. I suspect that passing a list of middlewares like this makes users less aware of the ordering of middlewares at the end of their setup.

Maybe we should consider disallowing the passing of middlewares and require later `app.middlewares.append()` etc.?

Or, lock the middlewares when they have been passed in, such that it can't be mixed with `.append()` or `setup()`. This allows a user to pass a fixed sequence of middlewares that will never change. If they need to use `setup()` or similar, then they must add all their middlewares as a separate step, paying attention to what order to add them along with the `setup()` calls.

### Additional context

#6789

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.