aio-libs / aio-libs/aiohttp

[Discussion] Ordering of middlewares=

Open
#6,798 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
16.5k
Forks
2.4k
Avg merge
17h 22m
Merged PRs (30d)
212

Description

### Describe the bug

Some users try to use `Application(middlewares=...)` and then use the `setup()` functions from other libraries, which add their own middlewares.

This can cause problems due to the ordering of middlewares. I suspect that passing a list of middlewares like this makes users less aware of the ordering of middlewares at the end of their setup.

Maybe we should consider disallowing the passing of middlewares and require later `app.middlewares.append()` etc.?

Or, lock the middlewares when they have been passed in, such that it can't be mixed with `.append()` or `setup()`. This allows a user to pass a fixed sequence of middlewares that will never change. If they need to use `setup()` or similar, then they must add all their middlewares as a separate step, paying attention to what order to add them along with the `setup()` calls.

### Additional context

#6789

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.