ai / ai/webp-in-css

Incompatibility between polyfill and plugin

Aberta
#52 3 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
JavaScript
Estrelas
343
Forks
26
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Hi Andrey,

Well, currently your polyfill uses the HTML `` element to inject the .webp or .no-webp class, depending on whether the browser is compatible or not.

You specify `Polyfill should be inserted in the ` in your README, but if you do this you'll get an error, because if the polyfill is injected into the `` at runtime the `` element doesn't yet exist you'll get an error like this :

`Uncaught TypeError: Cannot read properties of null (reading 'classList')`

I suggest replacing `document.body` in the polyfill.js file with `document.documentElement` in order to use the `` element for .webp or .no-webp class injection. There are a few logical changes to be made in the plugin.js file, and I'd be happy to make a pull request to fix the problem, or if you'd like to do it yourself.

If I've missed any information, please let me know. There may be a reason why you're using the `` element.

Thanks

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.