ai / ai/webp-in-css

Incompatibility between polyfill and plugin

Abierto
#52 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
343
Forks
26
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi Andrey,

Well, currently your polyfill uses the HTML `` element to inject the .webp or .no-webp class, depending on whether the browser is compatible or not.

You specify `Polyfill should be inserted in the ` in your README, but if you do this you'll get an error, because if the polyfill is injected into the `` at runtime the `` element doesn't yet exist you'll get an error like this :

`Uncaught TypeError: Cannot read properties of null (reading 'classList')`

I suggest replacing `document.body` in the polyfill.js file with `document.documentElement` in order to use the `` element for .webp or .no-webp class injection. There are a few logical changes to be made in the plugin.js file, and I'd be happy to make a pull request to fix the problem, or if you'd like to do it yourself.

If I've missed any information, please let me know. There may be a reason why you're using the `` element.

Thanks

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.