Incompatibility between polyfill and plugin
- Langage dominant
- JavaScript
- Étoiles
- 343
- Forks
- 26
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hi Andrey,
Well, currently your polyfill uses the HTML `` element to inject the .webp or .no-webp class, depending on whether the browser is compatible or not.
You specify `Polyfill should be inserted in the ` in your README, but if you do this you'll get an error, because if the polyfill is injected into the `` at runtime the `` element doesn't yet exist you'll get an error like this :
`Uncaught TypeError: Cannot read properties of null (reading 'classList')`
I suggest replacing `document.body` in the polyfill.js file with `document.documentElement` in order to use the `` element for .webp or .no-webp class injection. There are a few logical changes to be made in the plugin.js file, and I'd be happy to make a pull request to fix the problem, or if you'd like to do it yourself.
If I've missed any information, please let me know. There may be a reason why you're using the `` element.
Thanks
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.