adopted-ember-addons / adopted-ember-addons/validated-changeset

isDirty/isPristine don’t trigger computed property changes

未关闭
#164 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
38
派生
27
PR 合并指标
30 天内没有已合并 PR

描述

After updating `ember-changeset-validations` from 2.2.1 to 3.16.0, the computed properties that are dependent on `changeset.isDirty` are not updating when `changeset.isDirty` changes. This doesn't appear to be an issue for the other computed properties. Properties on the changeset that contain modified values trigger computed properties as expected.

Here is the project that recreates the issue. `isDirty/isPristine` computed properties do not get triggered. firstName property does get triggered as expected.

Github Link: [https://github.com/PVSAmulya/form-project](https://github.com/PVSAmulya/form-project)

When using ember-changeset 3.15.0 with ember-changeset-validations 2.2.1 `changeset.isDirty` computed property works as expected. I debugged this issue to validated-changeset.

There was a similar issue in ember-changeset for `isValid/isInvalid` that has been resolved.
[https://github.com/poteto/ember-changeset/issues/455](https://github.com/poteto/ember-changeset/issues/455)

Specific comment that is related to `isDirty` and `isPristine` on the PR that resolves the above issue.
[https://github.com/poteto/ember-changeset/pull/509#issuecomment-644344152](https://github.com/poteto/ember-changeset/pull/509#issuecomment-644344152)

Screen Shot 2022-03-03 at 1 07 28 PM

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。